This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
build: run ci test on pull requests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that our agent tests are not deterministic and across the previous commits they pass or fail on different steps. This makes them somewhat tricky to do in CI. We may want to revise what we test in different environments? |
|
yeah let's think about how we want to test the actual agents. I think we can probably lock them down to some extent? |
|
but approved in the meantime |
AlephNotation
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per default settings on repos, first-time contributors will need us to stamp their PRs before a test will run. This is good, because of our dependencies on other services for tests.
Had to amend a bit because NODE_ENV doesn't really set to CI, so we just look for CI to be true. Google Chrome does appear in Linux env, just as
google-chrome.