Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Test Search and Suggest Update #434

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Conversation

pengyin-shan
Copy link
Collaborator

@pengyin-shan pengyin-shan commented Jan 30, 2025

This PR is for #434 and #439. It updates the suggestion scoring system to include more results and introduces the trial version of the LLM-based search experience. Additionally, it incorporates layout adjustments following the latest design changes and fixes several minor bugs.

How to Test

  1. Navigate to the search page. The keyword search should be the default mode:
Screenshot 2025-02-07 at 10 09 44 AM
  1. Test the suggestion dropdown behavior: Start typing in the keyword search field. The suggestion dropdown should now correctly overlap the Geo search box on the map, fixing a previous issue: Screenshot 2025-02-07 at 10 09 56 AM

  2. Verify keyword search functionality: Perform various searches to confirm that keyword search still works as expected: Screenshot 2025-02-07 at 12 23 28 PM

  3. Switch to AI-based search mode: Click the "Chat" button to switch to AI search: Screenshot 2025-02-07 at 12 23 43 PM

  4. Test AI-based search: Type a question (e.g., "What is the greenspace condition in Champaign, IL?") and search.
    While searching, the mode switch, search, and clear buttons should be temporarily disabled to prevent conflicts caused by multiple triggered searches: Screenshot 2025-02-07 at 12 28 46 PM

  5. Review AI search results: You should now see the AI-generated results: Screenshot 2025-02-07 at 12 27 24 PM

  6. Switch back to keyword search: You can return to keyword search mode and test functionality as needed.

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for cheerful-treacle-913a24 ready!

Name Link
🔨 Latest commit 9099c04
🔍 Latest deploy log https://app.netlify.com/sites/cheerful-treacle-913a24/deploys/67a6409235f9550008948249
😎 Deploy Preview https://deploy-preview-434--cheerful-treacle-913a24.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mradamcox
Copy link
Contributor

mradamcox commented Feb 7, 2025

@pengyin-shan based on the latest demo, I have some thoughts about the map integration. To me, the ideal solution to the location/bbox search is not to have ChatGPT generate the Solr params for this (as you currently have it), but instead to have the ChatGPT results trigger a selection in the geocoding widget, assuming that is possible. That would take care of selecting the place in the map, zooming to it, and adding the bbox filter, instead of short-circuiting straight to the solr query, like the current setup. Do you think that is something you could explore before we merge this? Just wanted to put the idea out there.

@pengyin-shan pengyin-shan changed the title [WIP] Issue 431 update suggest AI Test Search and Suggest Update Feb 7, 2025
@pengyin-shan pengyin-shan marked this pull request as ready for review February 7, 2025 18:24
Copy link
Contributor

@mradamcox mradamcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is really cool, and looking really good. I'm sure we'll have some design changes to make, and more to do on the map integration, but it's in plenty good enough shape to merge into our development branch now.

@mradamcox mradamcox merged commit 5c7c1af into discovery_app Feb 11, 2025
4 checks passed
@mradamcox mradamcox deleted the issue_431_update_suggest branch February 11, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants