Set customdomain/range before updating (#685)

heavyai · Dec 3, 2024 · 3a0cc92 · 3a0cc92
1 parent 483d373
commit 3a0cc92
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/dist/charting.js b/dist/charting.js
@@ -81720,7 +81720,6 @@ function binningMixin(chart) {
 /* harmony import */ var __WEBPACK_IMPORTED_MODULE_4__utils_utils__ = __webpack_require__(4);
 /* harmony import */ var __WEBPACK_IMPORTED_MODULE_5__core_core__ = __webpack_require__(3);
 /* harmony import */ var __WEBPACK_IMPORTED_MODULE_6__utils_color_helpers__ = __webpack_require__(218);
-function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }
 
 
 
@@ -82019,8 +82018,8 @@ function bubbleChart(parent, chartGroup) {
       var domain = (_chart$customDomain = _chart.customDomain()) !== null && _chart$customDomain !== void 0 ? _chart$customDomain : [];
       var range = (_chart$customRange = _chart.customRange()) !== null && _chart$customRange !== void 0 ? _chart$customRange : [];
       if (_chart.colorMappingDomain().length > 0 && _chart.colorMappingRange().length > 0) {
-        _chart.colorMappingDomain(), _readOnlyError("domain");
-        _chart.colorMappingRange(), _readOnlyError("range");
+        domain = _chart.colorMappingDomain();
+        range = _chart.colorMappingRange();
       }
       if (domain.length === 0 && range.length === 0) {
         var newDomain = data.map(function (d) {
@@ -82038,6 +82037,8 @@ function bubbleChart(parent, chartGroup) {
         });
         _chart.customRange(_newRange);
       } else if (domain.length > 0) {
+        _chart.customDomain(domain);
+        _chart.customRange(range);
         Object(__WEBPACK_IMPORTED_MODULE_6__utils_color_helpers__["d" /* maybeUpdateDomainRange */])(_chart, data, function (d) {
           return d.key0;
         }, domain, range, true);

diff --git a/src/charts/bubble-chart.js b/src/charts/bubble-chart.js
@@ -488,6 +488,8 @@ export default function bubbleChart(parent, chartGroup) {
         const newRange = data.map((d, i) => _chart.getColor(d, i))
         _chart.customRange(newRange)
       } else if (domain.length > 0) {
+        _chart.customDomain(domain)
+        _chart.customRange(range)
         maybeUpdateDomainRange(_chart, data, d => d.key0, domain, range, true)
       }
     }