[FE-18033] Don't pass in stale domain to maybeUpdateAllOthers (#678)

* Don't pass in stale domain to maybeUpdateAllOthers * Update build files --------- Co-authored-by: Chris Matzenbach <[email protected]>
heavyai · Oct 25, 2024 · 7a13604 · 7a13604
1 parent 0467aac
commit 7a13604
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/dist/charting.js b/dist/charting.js
@@ -88336,8 +88336,8 @@ function pieChart(parent, chartGroup) {
     } else if (domain.length > 0) {
       Object(__WEBPACK_IMPORTED_MODULE_9__utils_color_helpers__["d" /* maybeUpdateDomainRange */])(_chart, pieData, function (d) {
         return d.data.key0;
-      }, domain, range);
-      Object(__WEBPACK_IMPORTED_MODULE_9__utils_color_helpers__["c" /* maybeUpdateAllOthers */])(_chart, pieData, domain, range);
+      }, domain, range, true);
+      Object(__WEBPACK_IMPORTED_MODULE_9__utils_color_helpers__["c" /* maybeUpdateAllOthers */])(_chart, pieData, _chart.customDomain(), _chart.customRange());
     }
     updateSlicePaths(pieData, arc);
     updateLabels(pieData, arc);

diff --git a/src/charts/pie-chart.js b/src/charts/pie-chart.js
@@ -481,8 +481,20 @@ export default function pieChart(parent, chartGroup) {
       const newRange = pieData.map((d, i) => _chart.getColor(d.data, i))
       _chart.customRange(newRange)
     } else if (domain.length > 0) {
-      maybeUpdateDomainRange(_chart, pieData, d => d.data.key0, domain, range)
-      maybeUpdateAllOthers(_chart, pieData, domain, range)
+      maybeUpdateDomainRange(
+        _chart,
+        pieData,
+        d => d.data.key0,
+        domain,
+        range,
+        true
+      )
+      maybeUpdateAllOthers(
+        _chart,
+        pieData,
+        _chart.customDomain(),
+        _chart.customRange()
+      )
     }
 
     updateSlicePaths(pieData, arc)