-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the EmbeddedServerHelper more dynamic by allowing more parameters in the constructor #230
base: master
Are you sure you want to change the base?
Conversation
…s in the constructor
I have created a config object which can be passed onto the EmbeddedServerHelper constructor. |
I wrote a EmbeddedServerConfigurator object which is used to configure the EmbeddedServerHelper. Other than that I have cleaned up the code a bit and added some tests. |
This feature is very interesting especially to use it in cassandra-unit |
Some files are in the wrong place. I'll close this request and open up a new one. |
What's the status of this ? Sean ? |
Hi all,
as sent over hector-users, I extendend the EmbeddedServerHelper to take more arguements and make use of a template .yaml file which gets filled with correct values at setup(..) time.
Also take an argument for an external log4j file which gets copied along into the folder of choice.
I kept both a the EmbeddedServerHelper(String yamlFile) and EmbeddedServerHelper() constructors with correct default values to act as a drop-in replacement. I ran all the available tests, so it should work.
Felipe