Dynamic Composite Types support for DoubleType #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f481153.
…ntry for the DoubleType in the alias to comparator map
|
Thanks for the PR.Let me know on the comment above and i'll pull it in. |
|
The revert was just because I was focus on Double. |
…egerSerializer for IntegerType
…egerSerializer for IntegerType
…egerSerializer for IntegerType
…egerSerializer for IntegerType
Conflicts: core/src/main/java/me/prettyprint/hector/api/ddl/ComparatorType.java
Conflicts: core/src/main/java/me/prettyprint/hector/api/ddl/ComparatorType.java core/src/test/java/me/prettyprint/hector/api/beans/DynamicCompositeTest.java kept my version of integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DoubleType wasn't one of the default types for the DynamicCompositeType.
Furthermore, the DoubleSerializer returned the BYTESTYPE instead of DOUBLETYPE as ComparatorType.
In such way the DCT stored in Cassandra a double with the alias ('b') of a ByteType with the possibility of issues for the comparator and some problems deserializing the value from the db.