Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Authentication - Azure Active Directory #4413

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Docs: Authentication - Azure Active Directory #4413

merged 1 commit into from
Jul 8, 2023

Conversation

pramitsingh0
Copy link

@pramitsingh0 pramitsingh0 commented Jul 7, 2023 •
edited by mrdrogdrog
Loading

Component/Part

Documentation

Description

This PR adds the documentation for Azure Active Directory Authentication.

Steps

  • Added / updated documentation
  • I read the contribution documentation and
    made sure that:
    • My commits are signed-off to accept the DCO.
    • This PR targets the correct branch: master for 1.x & docs, develop for 2.x

Related Issue(s)

#2656

mrdrogdrog
mrdrogdrog requested changes Jul 8, 2023
View reviewed changes
Copy link
Member

@mrdrogdrog mrdrogdrog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the file to the navigation in mkdocs.yml

@mrdrogdrog mrdrogdrog changed the title Docs: Authentication - Azure Active Directory Signed-off-by: Pramit… Docs: Authentication - Azure Active Directory Jul 8, 2023
mrdrogdrog
mrdrogdrog requested changes Jul 8, 2023
View reviewed changes
@mrdrogdrog
Copy link
Member

Please squash your commits into one.

@pramitsingh0
Copy link
Author

pramitsingh0 commented Jul 8, 2023 •
edited
Loading

Please squash your commits into one

Done, feel free to let me know if anything else is required.

mrdrogdrog
mrdrogdrog requested changes Jul 8, 2023
View reviewed changes
@mrdrogdrog mrdrogdrog requested a review from DerMolly July 8, 2023 18:22
@DerMolly DerMolly merged commit adec788 into hedgedoc:master Jul 8, 2023
@DerMolly
Copy link
Member

DerMolly commented Jul 8, 2023

Thank you @pramitsingh0!

@pramitsingh0
Copy link
Author

Glad I could be of help. And Thank you @mrdrogdrog for your help and patience with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerMolly DerMolly DerMolly approved these changes

@mrdrogdrog mrdrogdrog mrdrogdrog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pramitsingh0 @mrdrogdrog @DerMolly @GradienceBot