Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False error in GitHub Action execution #64

Closed
TysonMN opened this issue Apr 2, 2022 · 2 comments
Closed

False error in GitHub Action execution #64

TysonMN opened this issue Apr 2, 2022 · 2 comments

Comments

@TysonMN
Copy link
Member

TysonMN commented Apr 2, 2022

This build said it had an error, but the NuGet package was successfully published anyway.

@dharmaturtle, can you links/information you found about this issue?

@dharmaturtle
Copy link
Member

dharmaturtle commented Apr 3, 2022

Ah yeah, got distracted :D

That build failed because we bumped the dotnet version to 6.0.201. This is a known issue. I see 3 possible solutions:

  1. We can either go back to a prior version, e.g. 6.0.102. I'm not a fan of this because this API change is "by design", and we'll have to fix this anyway if we ever upgrade to a later version.
  1. Wait for our dependency on brandedoutcast/publish-nuget to fix the issue. This seems unlikely as the repo hasn't been updated since Jul 18, 2020.
  2. Switch to another "publish-nuget" dependency.

I'm leaning towards Option 3 at the moment. However, I'd like to follow the herd, and there's no clear "winner" yet, so I'll happily procrastinate on this issue until it becomes a "real" problem.

@TysonMN
Copy link
Member Author

TysonMN commented Jul 14, 2022

From April 3:

  1. Switch to another "publish-nuget" dependency.

I'm leaning towards Option 3 at the moment. However, I'd like to follow the herd, and there's no clear "winner" yet [...]

From May 5:

There is a good fork of it. Simply replace this part in your workflow with alirezanet/[email protected] and your are done

I made that switch in the commit referenced in GitHub before this commit.

@TysonMN TysonMN closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants