Shrink floating binary point types similar to the Haskell version #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Hedgehog 0.2.2 Shrink module's towardsFloat: https://github.com/hedgehogqa/haskell-hedgehog/blob/51ebefc972235d07f25a462b6edbfe3ce507ccbc/hedgehog/src/Hedgehog/Internal/Shrink.hs#L38-L62
moodmosaic
commented
May 26, 2017
| @@ -409,7 +409,7 @@ module Gen = | |||
|
|
|||
| /// Generates a random 64-bit floating point number. | |||
| let double : Gen<double> = | |||
| create Shrink.double Random.sizedDouble | |||
| create (Shrink.towardsDouble 0.0) Random.sizedDouble | |||
There was a problem hiding this comment.
I know that at some point we need to change Gen.double so that it takes a Range, similar to the other primitive combinators. I'd prefer to do this on a separate PR because Random.sizedDouble must be changed too and Seed.nextDouble must be added first. (Same also for Gen.float.)
|
|
|
Nice 👍 |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Hedgehog 0.2.2
Shrink.hsmodule's towardsFloat.