Added reportBool, reportRecheck, and reportRecheckBool #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharmaturtle
changed the title
TysonMN
approved these changes
Jan 15, 2021
moodmosaic
reviewed
Jan 15, 2021
There was a problem hiding this comment.
Many thanks for the pull request 🦔 We're more than happy to support Hedgehog.Xunit (and eventually move it inside @hedgehogqa, if you want to).
#266 should probably go first, which'll break this PR but I'll fix it once it's in.
- We could merge this one now, and perhaps Moved functions from Random to Gen #238, and plan for a release so we can get the Hedgehog.Linq stuff out.
- The rearrangements in Rearrange parameters for better chaining. #266 (and any other breaking changes) go into a final, pre-v1, release.
@TysonMN, what do you think?
|
I like merging this now. Let's merge in simple ones like this and make the more complicated PRs adjust. |
I'd like to move it in before v1.0 I'll probably revisit this after Experimental gets (partially?) merged. |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be easier for Hedgehog.Xunit to implement
[<Recheck(size, seed)>]ifreportRecheckexisted. I threw inreportBoolas a bonus.#266 should probably go first, which'll break this PR but I'll fix it once it's in.