-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the parameters of Range.exponentialFrom (and friends) #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some notes that should be resolved before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Left a few comments wrt styling.
Just checking - I believe I'm done addressing the comments/reviews on this PR. Please let me know if I overlooked something. |
Sorry for the delay in getting this through. @moodmosaic are you okay with these changes? |
LGTM 👍 💯 |
Thanks @dharmaturtle for the work you've done, it's always appreciated! |
Closes #313