Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the parameters of Range.exponentialFrom (and friends) #315

Merged
7 commits merged into from
Aug 16, 2021

Conversation

dharmaturtle
Copy link
Member

Closes #313

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some notes that should be resolved before we merge.

src/Hedgehog/Range.fs Outdated Show resolved Hide resolved
src/Hedgehog/Range.fs Outdated Show resolved Hide resolved
src/Hedgehog/Range.fs Outdated Show resolved Hide resolved
src/Hedgehog/Range.fs Outdated Show resolved Hide resolved
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Left a few comments wrt styling.

src/Hedgehog/Range.fs Show resolved Hide resolved
src/Hedgehog/Range.fs Outdated Show resolved Hide resolved
src/Hedgehog/Range.fs Show resolved Hide resolved
@ghost ghost added this to the 0.11.0 milestone Feb 22, 2021
@dharmaturtle
Copy link
Member Author

Just checking - I believe I'm done addressing the comments/reviews on this PR. Please let me know if I overlooked something.

@ghost
Copy link

ghost commented Aug 13, 2021

Sorry for the delay in getting this through. @moodmosaic are you okay with these changes?

@moodmosaic
Copy link
Member

LGTM 👍 💯

@ghost ghost merged commit 8e703f9 into hedgehogqa:master Aug 16, 2021
@ghost
Copy link

ghost commented Aug 16, 2021

Thanks @dharmaturtle for the work you've done, it's always appreciated!

@dharmaturtle dharmaturtle deleted the range_param_rename branch August 16, 2021 21:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the parameters of Range.exponentialFrom (and friends)
2 participants