Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct name and repo_name #188

Closed
wants to merge 1 commit into from
Closed

Distinct name and repo_name #188

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link

I created https://github.com/bazelbuild/bazel-central-registry/pull/1989/files

This makes the module name and repo_name distinct

@cpsauer
Copy link
Contributor

cpsauer commented May 17, 2024

Hi, Matthieu! Thanks for being the kind of person who tries to leave things better than you found them. Could I ask you to help me understand the underlying issue here? What are we trying to solve for by making the repo name different? (My best understanding is that it's some kind of migration setting for folks that want to change names?)

@cpsauer
Copy link
Contributor

cpsauer commented May 18, 2024

Hey, Matthieu! As in the other PR, would it work for your use case to use this tool as it's designed as a dev dependency?

That is
bazel_dep(name = "hedron_compile_commands", dev_dependency = True)
from the readme, rather than

`bazel_dep(
     name = "hedron_compile_commands",
     version = "",
 )

in your hessian2 PR.

(This tool is normally used directly as s dev dependency to make code editing and listing more ergonomic, and not brought in transitively. If you're using it for some other purpose, just lmk!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants