Manage extension configuration as plain JSON #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pdecat
force-pushed
the
f-extension-config
branch
from
fd4f61a to
a20469e
Compare
|
Hi @heimweh , thanks! Note that the travis build of master failed with the following error: cf. https://travis-ci.org/heimweh/go-pagerduty/builds/415930357 It probably requires a more recent version of golang as 1.8 does not support it. |
|
Hi @pdecat, thanks! should be fixed now. |
heimweh
pushed a commit
to PagerDuty/terraform-provider-pagerduty
that referenced
this pull request
Aug 16, 2018
* Update go-pagerduty from github.com/pdecat/go-pagerduty fork's f-extension-config branch:
govendor fetch github.com/heimweh/go-pagerduty/pagerduty::github.com/pdecat/go-pagerduty/pagerduty@=f-extension-config
* Manage extension configuration as plain JSON
* Add github.com/hashicorp/terraform/helper/validation dependencies
* Update vendored go-pagerduty dependency now that heimweh/go-pagerduty#22 is merged
* Replace custom json diff with terraform's structure.SuppressJsonDiff()
* Check extension config is set before trying to unmarshall it
* Document the service extension config field
* Fix indentation
* Fix storage of the JSON data returned by the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to manage the configuration of extensions.
I've got an example here with Slack extension: https://github.com/pdecat/terraform-provider-pagerduty/commit/ed531c38b45898a21e41f97289f46b18acd92a3d#diff-88dbff91359cd2b53c89698836a283cbR182
Note: OAuth authorization still needs be done by hand.
I'm prepping a PR for the terraform part.