-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight search results in buffer with / #1733
Comments
I think this functionality was recently merged with #1635 |
That seems to only highlight the search results in the file picker. I was talking about search in the buffer. |
Search is selection based though, a way to see all the results would be to use |
You can also |
That would produce a different behavior, though. Kakoune supports it. For instance, you can create a search highlighter this way:
|
Just high-lighting all the search result is not exactly the same as selecting all of them (and hence... highlighting) though. I would like to loop through all the matches, and once I find the match I'm interested in, stop and make changes (ONLY to the current match), and then continue. Having the next and previous matches highlighted helps me quickly navigate, as I can have a reasonable guess on where I would land before I even hit |
I was trying to implement this but I believe with how the editor is currently internally structured it might be worthwhile to investigate first to have some sort of overlay abstraction in it. The most obvious way in which I can see this being implemented today would be quite wasteful as repeated edits/inserts would likely have to re-execute the search or manual booktracking of the overlays just for the search would be necessary. |
I totally agree, the ability to highlight all search results in the buffer would be incredibly useful, something I used to do in neovim all the time before switching to Helix. |
Maybe easier now that virtual text #411 has been merged? |
You can press |
@hajarrashidi thanks - but this has already been suggested and also answered |
Hi.
Describe your feature request
I'd like an option to highlight the search results.
Thanks.
The text was updated successfully, but these errors were encountered: