Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent prompts #1080

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix inconsistent prompts #1080

merged 1 commit into from
Nov 12, 2021

Conversation

Omnikar
Copy link
Contributor

@Omnikar Omnikar commented Nov 11, 2021

No description provided.

@Omnikar Omnikar changed the title Make prompts consistent Fix inconsistent prompts Nov 11, 2021
Copy link
Member

@sudormrfbin sudormrfbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it to Global search: and Rename to: , with a space at the end for readability and without the hyphens.

@Omnikar
Copy link
Contributor Author

Omnikar commented Nov 11, 2021

I'm slightly less indifferent about the hyphen vs. space (though I do still prefer hyphen), but I definitely prefer not to begin prompts with capital letters. All the other prompts are already all-lowercase. Also, I think I recall @archseer saying somewhere that no space after the prompt is intentional, and I also agree with that.

@pickfire
Copy link
Contributor

I think global search should not be a prompt but be like the rest of the pickers.

@Omnikar
Copy link
Contributor Author

Omnikar commented Nov 12, 2021

I think global search should not be a prompt but be like the rest of the pickers.

But… global search needs a pattern to search for

@archseer
Copy link
Member

I think global search should not be a prompt but be like the rest of the pickers.

Yeah an interactive global search is what I wanted but the initial implementation uses a prompt for the query since it was simpler to implement. See #196, probably better to continue discuss it there

@archseer
Copy link
Member

that no space after the prompt is intentional

Yeah it's a bit easier to tell if you're typing a regex with a space at the start I think, I don't mind the lack of spacing

@archseer archseer merged commit 6d4409c into helix-editor:master Nov 12, 2021
@Omnikar Omnikar deleted the fix-prompts branch November 12, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants