Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default-yank-register option #11430

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

oworope
Copy link
Contributor

@oworope oworope commented Aug 5, 2024

Solution for the #11398

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use-case in #11398 can be covered by rebinding commands, see #2038 (comment)

While this is a small and straightforward patch, I'm not inclined to approve it unless there's another use-case that isn't already possible by rebinding commands

book/src/editor.md Outdated Show resolved Hide resolved
@oworope
Copy link
Contributor Author

oworope commented Aug 8, 2024

Rust is hard 😔

@the-mikedavis
Copy link
Member

See #2038 (comment), this actually might be preferrable to remapping commands since the clipboard yanking commands don't accept a different register. (So if you remap your keys to use those then you can't yank to another register)

book/src/editor.md Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis changed the title Add default-register option Add default-yank-register option Aug 16, 2024
oworope and others added 2 commits August 16, 2024 23:27
Co-authored-by: Michael Davis <[email protected]>
Co-authored-by: Michael Davis <[email protected]>
@oworope oworope marked this pull request as ready for review August 16, 2024 20:31
book/src/editor.md Outdated Show resolved Hide resolved
oops

Co-authored-by: Michael Davis <[email protected]>
@the-mikedavis the-mikedavis requested a review from archseer August 16, 2024 20:56
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Aug 28, 2024
wwmoraes added a commit to wwmoraes/dotfiles that referenced this pull request Oct 9, 2024
I gotta figure out the system clipboard integration in Kitty. Might as
well wait for helix-editor/helix#11430, as
changing the bindings breaks usage of other registries.

Signed-off-by: William Artero <[email protected]>
@the-mikedavis the-mikedavis merged commit 9e171e7 into helix-editor:master Nov 20, 2024
6 checks passed
jyn514 pushed a commit to jyn514/helix that referenced this pull request Nov 30, 2024
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
@David-Else
Copy link
Contributor

I can't seem to escape this correctly, can someone advise? Cheers!

default-yank-register = "\"+"

image

Not sure where that typo characterin is coming from, it is not in Helix.

@the-mikedavis
Copy link
Member

the-mikedavis commented Jan 15, 2025

For this field you want to supply the register character alone, so just + in this case:

[editor]
default-yank-register = "+"

should do the trick.

The "characterin" part is probably because we ignore newlines in the statusline and that is probably a split in a line in the error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants