Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make overlays (e.g. pickers) fullscreen #12311

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4a053bc
add cursorcolumn and cursorline to base16_transparent theme
salman-farooq-sh Jul 5, 2024
0e7a427
Merge branch 'helix-editor:master' into master
salman-farooq-sh Aug 15, 2024
e7ec19d
Merge branch 'helix-editor:master' into master
salman-farooq-sh Aug 23, 2024
102caaf
Merge branch 'helix-editor:master' into master
salman-farooq-sh Aug 27, 2024
6fb1aa2
Merge branch 'helix-editor:master' into master
salman-farooq-sh Sep 5, 2024
c185d40
remove-margins-from-overlay
salman-farooq-sh Sep 5, 2024
b12a522
Merge branch 'helix-editor:master' into master
salman-farooq-sh Sep 14, 2024
521d84f
Merge branch 'helix-editor:master' into master
salman-farooq-sh Sep 18, 2024
2f94246
Merge branch 'helix-editor:master' into master
salman-farooq-sh Sep 24, 2024
b606937
Merge branch 'helix-editor:master' into master
salman-farooq-sh Sep 25, 2024
ae4eaf0
Merge branch 'helix-editor:master' into master
salman-farooq-sh Sep 29, 2024
a5f0355
Merge branch 'helix-editor:master' into master
salman-farooq-sh Sep 30, 2024
46cf662
Merge branch 'helix-editor:master' into master
salman-farooq-sh Oct 14, 2024
5ad7319
remove-bottom-clip
salman-farooq-sh Oct 20, 2024
5cd7b0d
Merge branch 'master' of https://github.com/salman-farooq-sh/helix
salman-farooq-sh Oct 20, 2024
ef646f0
Merge branch 'helix-editor:master' into master
salman-farooq-sh Oct 20, 2024
feb4132
Merge branch 'helix-editor:master' into master
salman-farooq-sh Oct 31, 2024
2f134f5
Merge branch 'helix-editor:master' into master
salman-farooq-sh Nov 30, 2024
fc72600
Merge branch 'helix-editor:master' into master
salman-farooq-sh Dec 3, 2024
6717f50
Merge branch 'helix-editor:master' into master
salman-farooq-sh Dec 21, 2024
ee5f956
cleanup-and-comments
salman-farooq-sh Dec 21, 2024
7ad3d99
typo-correction
salman-farooq-sh Dec 22, 2024
4939e5a
slightly-adjust-comment-wording
salman-farooq-sh Dec 22, 2024
63f5b06
ui/picker.rs: remove a comment
salman-farooq-sh Dec 22, 2024
fe959c8
Merge branch 'helix-editor:master' into master
salman-farooq-sh Jan 1, 2025
e63f016
undo-picker-preview-ratio-change
salman-farooq-sh Jan 1, 2025
d24eaa1
undo-fullscreen-without-status-line-and-bring-back-old-code
salman-farooq-sh Jan 1, 2025
09685a0
make-overlaid-content-conditionally-take-all-the-space
salman-farooq-sh Jan 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helix-term/src/ui/overlay.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pub struct Overlay<T> {
pub fn overlaid<T>(content: T) -> Overlay<T> {
Overlay {
content,
calc_child_size: Box::new(|rect: Rect| clip_rect_relative(rect.clip_bottom(2), 90, 90)),
salman-farooq-sh marked this conversation as resolved.
Show resolved Hide resolved
calc_child_size: Box::new(|rect: Rect| clip_rect_relative(rect.clip_bottom(0), 100, 100)),
}
}

Expand Down
2 changes: 1 addition & 1 deletion helix-term/src/ui/picker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ impl<I: 'static + Send + Sync, D: 'static + Send + Sync> Component for Picker<I,
self.show_preview && self.file_fn.is_some() && area.width > MIN_AREA_WIDTH_FOR_PREVIEW;

let picker_width = if render_preview {
area.width / 2
salman-farooq-sh marked this conversation as resolved.
Show resolved Hide resolved
area.width * 3 / 8
} else {
area.width
};
Expand Down
Loading