-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a .deb file #12453
Merged
Merged
Generate a .deb file #12453
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2042027
.deb file generation with cargo-deb
janos-r ce409b4
Add Build Deb step to github workflows
janos-r 917e03f
Remove / from tag names
janos-r d6698f9
Merge branch 'helix-editor:master' into cargo-deb
janos-r 2993dbf
Review polish
janos-r 9da392c
Docs
janos-r 0a9de6c
Release binary optimization
janos-r 04512ce
Review - rewording
janos-r f610cbb
Update book/src/building-from-source.md
janos-r f9c57f9
Update book/src/building-from-source.md
janos-r 76572b2
Update book/src/building-from-source.md
janos-r 888d602
Update book/src/package-managers.md
janos-r 9030310
Update book/src/package-managers.md
janos-r 086cff7
Update book/src/package-managers.md
janos-r ef07562
Update book contents
janos-r 38f969d
Keep opt profile
janos-r d981e08
Update book/src/package-managers.md
janos-r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#!/usr/bin/env sh | ||
|
||
HELIX_RUNTIME=/usr/lib/helix/runtime exec /usr/lib/helix/hx "$@" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep two profiles:
--release
is intended for quick builds of develop, and is what anyone running fromdevelop
is using. These users will be the first to encounter bugs so we deliberately keep the backtraces on so we get usable bug reports. I also often use--release
several times per day/when testing because debug builds are much less performant.Release builds should use
--opt
to build the smallest and most performant binary, at the expense of lengthy compile times.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so from the current PR, I will rename
release
toopt
in both the manifest and the release CI.I will keep a
release
profile in the manifest as it was before, with just thin lto and without strip. I hope I understood you correctly there. I am glad that the release CI will use an optimized build from now on. Even though it will not be called "release".Why remove them? If Helix makes it to the Debian and Ubuntu repositories and you remove .deb from the releases, the users would have to stay on an old repository version without enjoying any of the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, that's actually a good catch, the release CI was definitely intended to use
--profile opt
, must have been oversight.I prefer to hand off packaging to distributions if we can because it's just another maintenance burden. e.g. if
cargo deb
becomes out of date or unmaintained. We've already had issues with cross compilation before because thecargo-cross
images we were using were a couple years out of date with no upstream updates.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo-deb
is a dependency, that's true. Non the less I hope you can keep shipping these DEBs as long as possible. It is the best way how to install software of this kind on Debian, Ubuntu, Mint, etc.I made the profile name changes as you wished. I still think
release
should be final and the current release profile feels more like "testing", but whatever. I am happy that Helix now ships an even more performant binary 🚀️ and a well integrated Deb ❤️I tested this latest build on Mint21 and it seams fine 👍️
If you are ok with it, merge away ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like once Debian adds Helix, we might find ourselves back at square one for getting the latest version through Homebrew. Oh well! 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never used homebrew on linux and I don't plan on starting!
I really hope archseer keeps this DEB around while cargo-deb still works.
There is also the PPA maintained by Maveonair. It's just that Helix set a rust-version (in manifest) that is newer than LTS Ubuntu and so it can't be built anymore on launchepad. That was actually the cause that pushed me to make this DEB build. If Helix keeps a relatively old rust-version in the manifest, we could still get the package through the PPA.