Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Picker titles #12520

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Picker titles #12520

wants to merge 4 commits into from

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Jan 13, 2025

Pickers now have titles, making it easier to tell what the picker does at a glance

It also gives us flexibility, for when we want to add additional contextual information into the picker which cannot be shown with the columns.

For instance, #11285 would benefit from displaying the current directory of the file picker.

image

picker type title
thread_picker -
dap_launch -
dap_switch_stack_frame -
diag_picker Diagnostics
symbol_picker Document Symbols
lsp_workspace_command LSP Commands
workspace_symbol_picker Workspace Symbols
goto_reference Goto Reference
goto_single_impl Goto Implementation
file_picker Files
command_palette Commands
changed_file_picker Changed Files
jumplist_picker Jump List
buffer_picker Buffers
global_search Global Search

Closes #10186

@nik-rev
Copy link
Contributor Author

nik-rev commented Jan 16, 2025

reverted

~Note: I made it so that the titles are in the center instead of the left. ~

To do this I made a TitlePosition::{Left,Center} enum. This is how it looks like:

image

@darshanCommits
Copy link
Contributor

personally I think the left looked better, but okay not anything major.

@David-Else
Copy link
Contributor

I also think the left looked much better, thanks for this great PR!

@nik-rev
Copy link
Contributor Author

nik-rev commented Jan 16, 2025

Ok, since 3 of you said you prefer the old look, I'll revert it!

@nik-rev nik-rev force-pushed the picker-title branch 3 times, most recently from 5ebd086 to 5aad11b Compare January 16, 2025 10:23
@nik-rev nik-rev requested a review from the-mikedavis January 16, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants