-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Picker titles #12520
Open
nik-rev
wants to merge
4
commits into
helix-editor:master
Choose a base branch
from
nik-rev:picker-title
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Picker titles #12520
+41
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpaju
reviewed
Jan 15, 2025
TornaxO7
approved these changes
Jan 16, 2025
personally I think the left looked better, but okay not anything major. |
I also think the left looked much better, thanks for this great PR! |
Ok, since 3 of you said you prefer the old look, I'll revert it! |
nik-rev
force-pushed
the
picker-title
branch
3 times, most recently
from
January 16, 2025 10:23
5ebd086
to
5aad11b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickers now have titles, making it easier to tell what the picker does at a glance
It also gives us flexibility, for when we want to add additional contextual information into the picker which cannot be shown with the columns.
For instance, #11285 would benefit from displaying the current directory of the file picker.
Closes #10186