Goto definition: support for multiple lsps #12724
Conversation
Fall back to next configured language server if previous did not find a location to go to.
| items = to_locations(location); | ||
| offset_encoding = encoding; |
There was a problem hiding this comment.
It looks like this uses the response from the last language server to respond successfully. I believe we want to merge the items instead
There was a problem hiding this comment.
My test case for this was configuring typescript files to have both the typescript and angular language servers, in that order. So usually the first response from the typescript language server was fine, except for template strings, where angular would respond instead. So simply using the first valid response from the configured language servers in order was sufficient. But I think this should be fine as well, I just didn't want for goto definition to open a selection popup in the case that multiple language servers respond.
There was a problem hiding this comment.
This has however introduced a new issue: #12732
#11689