Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementer for (config driven) ordered lists. #3688

Conversation

aikomastboom
Copy link
Contributor

@aikomastboom aikomastboom commented Sep 4, 2022

A little spin-off from #2977

the-mikedavis commented #2977 (comment)
Code-wise this looks fine to me but IMO toggling a boolean is conceptually different from increment/decrement. Even as a standalone binding or feature I think this is too specific: I don't see much value over editing the boolean by hand.

aikomastboom commented #2977 (comment)
I understand your concern about it being "conceptually different", however there are only so many keybindings to remember and using C-a to scroll thru an ordered enumeration would make sense to me. Eg. [0,1,2,3,...], [true,false], [yes,no], [a,b,c,...], [red,green,blue,...16 base colors/ or colors already in use in eg. a theme file]. Agreed it will not always make sense to use this feature, however it would be up to user to choose what feature to use/apply when?

another sequence I can think of is musical notes: c, c#, d, e, f, f#, g, a, b

@kirawi kirawi added A-core Area: Helix core improvements S-waiting-on-review Status: Awaiting review from a maintainer. S-needs-discussion Status: Needs discussion or design. labels Sep 13, 2022
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too niche for core, in my opinion.

@pascalkuthe
Copy link
Member

I am closing this as stale as this PR has a lot of conflicts. I also don't see us going forward with this as it's too niche for core. Thjs can already be implemented with pipe instead and could be a simple function in your keymap once #10389 lands.

Thank you for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Helix core improvements S-needs-discussion Status: Needs discussion or design. S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants