Only render the auto-complete menu if it intersects with signature help #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
A-helix-term
kirawi
force-pushed
the
signature-completion-overlap_2
branch
from
1beea06 to
7ccb4c2
Compare
kirawi
added
the
E-testing-wanted
kirawi
force-pushed
the
signature-completion-overlap_2
branch
from
7ccb4c2 to
cdf81c1
Compare
kirawi
changed the title
|
One slight issue is that if you delete the retrigger character fast enough, the auto-complete popup will show again for that field. If you delete it after a while, the signature help will pop instead. |
sudormrfbin
reviewed
Feb 4, 2023
5 tasks
kirawi
force-pushed
the
signature-completion-overlap_2
branch
from
11e97c2 to
4ca0c93
Compare
|
Replaced by #5842 ? |
|
#5842 handles overlap of the completion popup and the documentation popup of the currently selected completion (the popup that gets rendered on the right of the completion popup) whereas this PR handles overlap of signature help and completion popup so it's different in scope. Both aim to improvement the popup experience :) |
kirawi
commented
Feb 9, 2023
Proful
reviewed
Feb 9, 2023
kirawi
removed
the
E-testing-wanted
kirawi
force-pushed
the
signature-completion-overlap_2
branch
from
e5becba to
af6ab4d
Compare
This was referenced Feb 22, 2023
pascalkuthe
added a commit
to pascalkuthe/helix
that referenced
this pull request
Mar 30, 2023
pascalkuthe
added a commit
to pascalkuthe/helix
that referenced
this pull request
Mar 30, 2023
pascalkuthe
added a commit
to pascalkuthe/helix
that referenced
this pull request
Mar 30, 2023
pascalkuthe
added a commit
to pascalkuthe/helix
that referenced
this pull request
Mar 30, 2023
pascalkuthe
added a commit
to pascalkuthe/helix
that referenced
this pull request
Mar 31, 2023
pascalkuthe
added a commit
to pascalkuthe/helix
that referenced
this pull request
Mar 31, 2023
archseer
pushed a commit
that referenced
this pull request
Mar 31, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5495 because it required moving
Completioninto its own layer in the compositor. This one simply checks if the two intersect, and will always defer to the auto-complete menu if they do.Closes #3821