(rename) View.doc -> View.doc_id #6067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibbz00
force-pushed
the
clarify-doc_id
branch
from
e5b9adf to
a59dfcb
Compare
This was referenced Feb 22, 2023
kirawi
added
A-helix-term
pickfire
reviewed
Mar 22, 2023
|
Sorry, I think we're just not going to merge this. This falls under "personal preferences" and breaks a lot of other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicting PRs (7)
#5812 #6056 #6061 #4642 #4726 #2869 #3239
* That are mergeable with master and pass all CI checks as of 2023-02-22