Fix Component implementations for Picker #7382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handle_event, required_size, and cursor functions were mistakenly moved into the `impl Picker` rather than the `impl Component for Picker` block when merging the Picker and FilePicker, causing bugs like the picker ignoring all input and not rendering the cursor position correctly.
the-mikedavis
added
C-bug
|
Looks like codeberg is having an outage and that's failing the CI because of the grammar fetch step https://status.codeberg.org/status/codeberg |
pascalkuthe
approved these changes
Jun 19, 2023
SilverCoder
approved these changes
Jun 19, 2023
Merged
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handle_event, required_size, and cursor functions were mistakenly moved into the
impl Pickerrather than theimpl Component for Pickerblock when merging the Picker and FilePicker (whoops! 😅), causing bugs like the picker ignoring all input and not rendering the cursor position correctly.Closes #7379