Fix: #7502 #7503
Closed
Fix: #7502 #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2023
Closed
|
Duplicate of #5242 also see Mike's comments |
|
Ahh, my mistake, I misinterpreted what he meant at first. Closing in favor of sending in another PR that can leverage the other register PRs I've sent in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix itself was a one-liner, but I added a test for it anyway. I'm interested in working on register histories, so I might as well get started with setting up the necessary test scaffolding here.
The test was placed in
info.rsbecauseRegisteris in core, which can't havehelix-viewas a dependency. Not being able to place it inregisters.rsforced me to make theinnerfield public. Maybe we should discuss if it would be appropriate to moveRegister(s) tohelix-view.