Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hoon #9024

Closed
wants to merge 0 commits into from
Closed

Add Hoon #9024

wants to merge 0 commits into from

Conversation

ilyakooo0
Copy link
Contributor

No description provided.

the-mikedavis
the-mikedavis reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helix needs queries under runtime/queries/hoon/highlights.scm in order to provider syntax highlighting: https://docs.helix-editor.com/master/guides/adding_languages.html#queries

@kirawi kirawi added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Dec 8, 2023
the-mikedavis
the-mikedavis reviewed Dec 8, 2023
View reviewed changes
gabydd
gabydd suggested changes Dec 8, 2023
View reviewed changes
languages.toml Outdated
Comment on lines 2956 to 2958
[[grammar]]
name = "hoon"
source = { git = "https://github.com/urbit-pilled/tree-sitter-hoon", rev = "1d5df35af3e0afe592832a67b9fb3feeeba1f7b6" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this below the language definition so it's formatted the same as the other languages

@ilyakooo0 ilyakooo0 requested a review from gabydd December 9, 2023 01:25
@gabydd
Copy link
Member

gabydd commented Dec 9, 2023

Looks like there is a language server: https://github.com/urbit/hoon-language-server might be nice to add the config for it if it works and add it to the wiki. If not that's not a blocker

@ilyakooo0
Copy link
Contributor Author

Running the language server isn't as simple as running a binary at the root of the project. There's more setup involved.

From what I heard the language server doesn't work that well and nobody actually uses it.

the-mikedavis
the-mikedavis previously approved these changes Dec 10, 2023
View reviewed changes
@the-mikedavis the-mikedavis changed the title Added Hoon Add Hoon Dec 10, 2023
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2023
the-mikedavis
the-mikedavis reviewed Dec 27, 2023
View reviewed changes
languages.toml Outdated
[[grammar]]
name = "hoon"
source = { git = "https://github.com/urbit-pilled/tree-sitter-hoon", rev = "1d5df35af3e0afe592832a67b9fb3feeeba1f7b6" }

name = "janet"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the merge cut off some lines. The Hoon line at the top here can be removed and the name = "janet" line should have a line that says [[language]] above it

@ilyakooo0 ilyakooo0 closed this Dec 30, 2023
@ilyakooo0 ilyakooo0 mentioned this pull request Dec 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis left review comments

@gabydd gabydd gabydd approved these changes

@archseer archseer Awaiting requested review from archseer

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilyakooo0 @gabydd @the-mikedavis @kirawi