-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/release arm64 based images #139
Conversation
@mathew-fleisch thanks for this PR can you please sign the DCO? |
Signed-off-by: mathew-fleisch <[email protected]>
@cpanato done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
hey @cpanato When would the next release go out? I can't test/use the arm64 version until the next release I assume 😏 |
I will review the things and maybe next week but you can build in your side and test it :) |
😞 I tried and failed to build. Not sure why it would need an existing binary to build new binaries (i'm new to mage). I followed the release flow in this repo's github actions, running
|
nvm. I was able to build with the setup.sh and build.sh scripts. I was trying to run the mage build command directly and was getting the above error. I also had to manually install the goreleaser tool. After that, the build ran successfully (except it obviously couldn't actually push to the registry without credentials) and I was able to see the two new binaries I was expecting (linux_arm64 and darwin_arm64):
And when I copied the binary to an linux_arm64 device I was able to run it successfully:
I don't have an m1 mac to test the darwin_arm64 binary that I built, but I expect it to work just as well. 🤷 I guess it'd be tricky to backfill previous release versions with arm64 binaries |
No description provided.