Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/release arm64 based images #139

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Build/release arm64 based images #139

merged 1 commit into from
Oct 28, 2021

Conversation

mathew-fleisch
Copy link
Contributor

No description provided.

@cpanato
Copy link
Member

cpanato commented Oct 23, 2021

@mathew-fleisch thanks for this PR can you please sign the DCO?

Signed-off-by: mathew-fleisch <[email protected]>
@mathew-fleisch
Copy link
Contributor Author

@cpanato done.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cpanato cpanato merged commit 6342f9f into helm:main Oct 28, 2021
@mathew-fleisch
Copy link
Contributor Author

hey @cpanato When would the next release go out? I can't test/use the arm64 version until the next release I assume 😏

@cpanato
Copy link
Member

cpanato commented Oct 29, 2021

hey @cpanato When would the next release go out? I can't test/use the arm64 version until the next release I assume 😏

I will review the things and maybe next week

but you can build in your side and test it :)

@mathew-fleisch
Copy link
Contributor Author

mathew-fleisch commented Oct 29, 2021

😞 I tried and failed to build. Not sure why it would need an existing binary to build new binaries (i'm new to mage). I followed the release flow in this repo's github actions, running ./setup.sh then mage -v checkLicenseHeaders then mage -v lint (with one shellcheck warning SC2155) and finally tried running mage -v build and mage -v release both failed to find an existing goreleaser binary. Any advice @cpanato ? Maybe this should go in a separate issue 🤷
@cpanato advice?

mage -v build
Running target: Build
exec: goreleaser release --rm-dist --snapshot
Error: failed to run "goreleaser release --rm-dist --snapshot: exec: "goreleaser": executable file not found in $PATH" 

This was referenced Nov 1, 2021
@mathew-fleisch
Copy link
Contributor Author

nvm. I was able to build with the setup.sh and build.sh scripts. I was trying to run the mage build command directly and was getting the above error. I also had to manually install the goreleaser tool. After that, the build ran successfully (except it obviously couldn't actually push to the registry without credentials) and I was able to see the two new binaries I was expecting (linux_arm64 and darwin_arm64):

$ ls *.tar.gz
chart-releaser_v1.2.1-next_darwin_amd64.tar.gz
chart-releaser_v1.2.1-next_linux_arm64.tar.gz
chart-releaser_v1.2.1-next_darwin_arm64.tar.gz
chart-releaser_v1.2.1-next_linux_armv6.tar.gz
chart-releaser_v1.2.1-next_linux_amd64.tar.gz

And when I copied the binary to an linux_arm64 device I was able to run it successfully:

$ ./cr version
Version:         v1.2.1
Git commit:      cc39dd44533ba0e2d72f15cd516d986eb8bcc70e
Date:            2021-11-01T21:57:22Z
License:         Apache 2.0
$ uname -m
aarch64
$ uname
Linux

I don't have an m1 mac to test the darwin_arm64 binary that I built, but I expect it to work just as well. 🤷

I guess it'd be tricky to backfill previous release versions with arm64 binaries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants