force the namespace deletion by updating the finalizers in the namespace obj #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace object Signed-off-by: Carlos Panato <[email protected]>
unguiculus
reviewed
Feb 19, 2019
Signed-off-by: Carlos Panato <[email protected]>
Signed-off-by: Reinhard Nägele <[email protected]>
Signed-off-by: Reinhard Nägele <[email protected]>
cpanato
commented
Mar 1, 2019
Signed-off-by: Reinhard Nägele <[email protected]>
unguiculus
force-pushed
the
force-namespace-deletion
branch
from
7ca0eaa to
1bfceb5
Compare
Signed-off-by: Reinhard Nägele <[email protected]>
unguiculus
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After the namespace deletion sometimes the namespace get stuck in the
Terminatingphase forever and we need to use the script from @unguiculus (https://gist.github.com/unguiculus/d915e911ba04f1f97ecea4f617a2eef5) to remove the namespaces.This PR introduces the same login in the bash script to the chart-testing, when we check if the namespace still exists we apply the logic to force remove the namespace.
note: for example, last week in the Helm Chart CI Cluster we had around 900 namespaces in Terminating phase.