Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goreleaser docker.binary deprecation notice #121

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

jlegrone
Copy link
Member

@jlegrone jlegrone commented Mar 4, 2019

What this PR does / why we need it:

Addresses warning message during build.sh execution:

DEPRECATED: `docker.binary` should not be used anymore, check https://goreleaser.com/deprecations#docker-binary for more info.

Link: https://goreleaser.com/deprecations/#docker-binary

Which issue this PR fixes

Special notes for your reviewer:

@helm-bot helm-bot added size/XS and removed size/XS labels Mar 4, 2019
@jlegrone
Copy link
Member Author

jlegrone commented Mar 4, 2019

Circle seems to really be having networking issues today...

@helm-bot helm-bot added size/XS and removed size/XS labels Mar 4, 2019
@jlegrone jlegrone force-pushed the feature/fix-goreleaser-deprecation branch from 263fe65 to e969c9b Compare March 4, 2019 19:43
@helm-bot helm-bot added size/XS and removed size/XS labels Mar 4, 2019
@jlegrone jlegrone force-pushed the feature/fix-goreleaser-deprecation branch from e969c9b to a2bb9a9 Compare March 4, 2019 19:44
@helm-bot helm-bot added size/XS and removed size/XS labels Mar 4, 2019
@jlegrone
Copy link
Member Author

jlegrone commented Mar 4, 2019

cc @unguiculus

pkg/util/util.go Outdated Show resolved Hide resolved
@jlegrone jlegrone force-pushed the feature/fix-goreleaser-deprecation branch from a2bb9a9 to 8fdc9f9 Compare March 5, 2019 14:30
@helm-bot helm-bot added size/XS and removed size/XS labels Mar 5, 2019
@unguiculus unguiculus merged commit 60640c0 into helm:master Mar 11, 2019
cpanato referenced this pull request in cpanato/chart-testing Jul 6, 2023
Signed-off-by: cpanato <[email protected]>

Signed-off-by: cpanato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants