Fix excluded chart when chart-dirs is multi-level #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nekottyo <[email protected]>
nekottyo
force-pushed
the
excludechart-multi-level-chart
branch
from
7d978f0 to
c86965c
Compare
|
@unguiculus @davidkarlsen Can you please review and merge? |
|
I'd love to see some care on the PR as well :( |
|
@davidkarlsen @cpanato @unguiculus is there anything blocking this PR from getting merged? Is there a way to help? |
|
@davidkarlsen @cpanato @unguiculus I would like to use this fix. If there is no problem, I would like you to merge and release it. |
cpanato
approved these changes
Nov 25, 2021
patrickhuy
approved these changes
Dec 3, 2021
|
@cpanato could you comment on what is blocking this? The change would be really useful for us and it seems rather low risk |
|
@davidkarlsen @cpanato can you share your thoughts on this? Is there a problem with this PR that one could work on resolving? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed excluded-charts not working if chart-dirs had child directories more than one level.
Which issue this PR fixes : fixes #311
Signed-off-by: nekottyo [email protected]