feat: verify if targetBranch is present in git repo #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a targetBranch is not present in the git repository the
ct list-changed
command will fail. The error message for this is not really meaningful.This PR will validate if the branch exists and throw a error message which the user will understand.
Because the default branch in GitHub changed from
master
tomain
this is a common problem users are facing.I've built the chart-testing and tested it with master branch as follows:
Which issue this PR fixes:
closes #330
Special notes for your reviewer:
I am not sure if I should add a test here..
other functions are not really care about it as
FileExistsOnBranch
for example:chart-testing/pkg/chart/chart_test.go
Lines 30 to 32 in 89d3494
related to (Breaking change) chore: change default target-branch to main #510