Support installation to existing namespace #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlegrone
force-pushed
the
feature/configure-namespace
branch
from
2ad7c29 to
6bc17a3
Compare
jlegrone
commented
Nov 17, 2018
jlegrone
commented
Nov 17, 2018
|
/assign @unguiculus |
|
I will need some time to review this. Please bear with me. |
unguiculus
requested changes
Dec 7, 2018
jlegrone
force-pushed
the
feature/configure-namespace
branch
from
6bc17a3 to
beab945
Compare
jlegrone
force-pushed
the
feature/configure-namespace
branch
from
beab945 to
175dd3c
Compare
unguiculus
reviewed
Dec 8, 2018
Signed-off-by: Jacob LeGrone <[email protected]>
Signed-off-by: Jacob LeGrone <[email protected]>
jlegrone
force-pushed
the
feature/configure-namespace
branch
from
175dd3c to
2caa7d9
Compare
jlegrone
changed the title
BREAKING CHANGE: InstallWithValues and LintWithValues should now be used in place of Install and Lint. Signed-off-by: Jacob LeGrone <[email protected]>
jlegrone
force-pushed
the
feature/configure-namespace
branch
from
2caa7d9 to
320af7a
Compare
Signed-off-by: Jacob LeGrone <[email protected]>
jlegrone
force-pushed
the
feature/configure-namespace
branch
from
a521443 to
bb45244
Compare
unguiculus
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two flags to the
installcommand:namespaceandrelease-label. Ifnamespaceis specified, releases will target that namespace andrelease-labelwill be used to select deployments and pods for readiness and reading log output.Fixes #34
I'm marking this as a WIP to gather feedback on the design (and whether we want to enable this functionality -- I wasn't totally clear on that based on the discussion so far in #34). I'll be happy to add more tests for this change if desired. 😄