-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for providing credentials when adding chart-repositories #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I agree this is something we need, but I think I'd rather go a different route here. We already have helm-extra-args
for installing charts. We need something like this for helm repo
as well. How about adding helm-repo-extra-args
? This would be more consistent and not only allow specifying username and password but also TLS arguments.
Seems like a nicer solution! I pushed a variant with a so you can do something like this ct lint --chart-repos "private=https://private,ambassador=https://www.getambassador.io" \
--helm-repo-extra-args "private=--username user --password secret" \
--helm-repo-extra-args "ambassador=--no-update" Or yaml config: chart-repos:
- incubator=https://incubator
- private=https://private
helm-repo-extra-args:
- private=--username test --password secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ct doc-gen
to generate the documentation. It seems you updated it manually.
…n adding chart repos Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
@unguiculus pr updated and rebased :) |
Signed-off-by: Markus Maga <[email protected]>
What this PR does / why we need it:
Add support for providing chart repo credentials when adding private chart repos
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
First time writing go, So be nice <3