Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Storage Class is a moving target #210

Closed
TerraTech opened this issue Nov 6, 2016 · 5 comments
Closed

Storage Class is a moving target #210

TerraTech opened this issue Nov 6, 2016 · 5 comments

Comments

@TerraTech
Copy link

I'm currently running CoreOS-1185.3.0 and hyperkube-v1.4.5_coreos.0

The charts are unable to start due to the PVCs not being able to claim the PVs. This is due to the 'volume.alpha.kubernetes.io/storage-class' plugin not being available. Also, there is no implied promotion from 'alpha' ==> 'beta' level. From the code, it would seem that 'alpha' support will be dropped from the code in:
https://github.com/kubernetes/kubernetes/pull/29006/files#diff-19005c632cb9e1783ab407d1c09af709R1410

Are there any objections for a PR with a mass search-n-replace to upgrade the storage class annotation to beta level? Otherwise, if backwards compatibility is a desire, then annotations like this should be parameterized and set it in a global config with a reasonable default.

In all honesty, I'd like to have the option to drop the storage-class annotation entirely and let it pull from our default persistent storage pool.

@lachie83
Copy link
Contributor

lachie83 commented Nov 11, 2016

Let's move them all to beta

@TerraTech
Copy link
Author

@lachie83 PR #213 created

@prydonius
Copy link
Member

@TerraTech @lachie83 see #116 (comment)

Would you be able to update #213 with the information from that comment? Also any objections to closing this issue in favour of #116?

@TerraTech
Copy link
Author

@prydonius In light of #116 (comment) and the comments about cluster portability, I have no problem with having #116 supercede this, as well as #213 being closed out. That PR was just a fast way to fixup the alpha. to beta. StorageClass problem we were having and we surmised that others were hitting it too. I would rather see this solved in a portable way since Charts are going to be installed in just about every environment you can think of. Ours is a bare-metal cluster.

@prydonius
Copy link
Member

Great, I've closed out this and #213 for the time being - thanks for bringing up the issue @TerraTech - if you have the time to implement the suggested change in #116, that would be great, but if not I'll try to get round to it within the next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants