Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Adding chart for cluster-autoscaler overprovisioning #10100

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Adding chart for cluster-autoscaler overprovisioning #10100

merged 3 commits into from
Jan 22, 2019

Conversation

mmingorance-dh
Copy link
Contributor

@mmingorance-dh mmingorance-dh commented Dec 18, 2018 •
edited
Loading

What this PR does / why we need it:

This chart creates an easy way to overprovision a cluster.

Special notes for your reviewer:

This approach is the current recommended method to achieve overprovisioning.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2018
@max-rocket-internet
# This is a combination of 2 commits.
292604f 
# This is the 1st commit message:

Initial commit

Signed-off-by: Max Williams <[email protected]>

# This is the commit message helm#2:

updating sources
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2018
@max-rocket-internet
Commit Sign-off
8694437 
Signed-off-by: Miguel Angel Mingorance Fernandez <[email protected]>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2018
@mmingorance-dh
Copy link
Contributor Author

/assign @foxish

Updating README table
cf68cf5 
Signed-off-by: Miguel Angel Mingorance Fernandez <[email protected]>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2018
@max-rocket-internet
Copy link
Contributor

Any update @foxish ? Or @unguiculus or maybe @paulczar ? Thanks!

@max-rocket-internet
Copy link
Contributor

Or @prydonius or @sameersbn or @seanknox ? Thanks!

unguiculus
unguiculus suggested changes Jan 17, 2019
View reviewed changes
stable/cluster-overprovisioner/templates/priorityclass-default.yaml
apiVersion: scheduling.k8s.io/{{ template "PriorityClass.apiVersion" . }}
kind: PriorityClass
metadata:
name: {{ .Values.priorityClassDefault.name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply the same naming logic for PriorityClasses as we suggest for service accounts using helper templates?

See https://github.com/helm/helm/blob/master/docs/chart_best_practices/rbac.md#using-rbac-resources

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. I guess this doesn't make sense here.

@unguiculus
Copy link
Member

/ok-to-test

@mmingorance-dh
Copy link
Contributor Author

@mmingorance-dh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e cf68cf5 link /test pull-charts-e2e
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Could this issue be related with apiVersion defined in the Chart?
I saw that PodPriority is now v1

@unguiculus
Copy link
Member

Might be due to our K8s version, which is still at 1.10. I'll try and get the test cluster updated soon.

@mmingorance-dh
Copy link
Contributor Author

We are currently running 1.10.6 with PodPriority feature enabled (as it's still on beta)

@max-rocket-internet
Copy link
Contributor

As per the README: Kubernetes 1.11+ with Beta APIs enabled or 1.8-1.10 with alpha APIs enabled

@unguiculus
Copy link
Member

/retest

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmingorance-dh, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5649162 into helm:master Jan 22, 2019
victorboissiere pushed a commit to victorboissiere/charts that referenced this pull request Jan 24, 2019
Adding chart for cluster-autoscaler overprovisioning (helm#10100)
a4ef55a 
* # This is a combination of 2 commits.
# This is the 1st commit message:

Initial commit

Signed-off-by: Max Williams <[email protected]>

# This is the commit message helm#2:

updating sources

* Commit Sign-off

Signed-off-by: Miguel Angel Mingorance Fernandez <[email protected]>

* Updating README table

Signed-off-by: Miguel Angel Mingorance Fernandez <[email protected]>
Signed-off-by: Victor Boissiere <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unguiculus unguiculus unguiculus approved these changes

Assignees

@foxish foxish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmingorance-dh @max-rocket-internet @unguiculus @k8s-ci-robot @foxish @helm-bot