Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Trim global section to avoid empty line to be indented #10204

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Dec 21, 2018

This fix prometheus.yml output display when using kubectl get configmap prometheus-server

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2018
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2018
This fix prometheus.yml output display when using `kubectl get configmap prometheus-server`

Signed-off-by: Sylvain Rabot <[email protected]>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2018
@sylr
Copy link
Contributor Author

sylr commented Jan 2, 2019

@mgoodness @gianrubiocan we merge this please ?

Copy link
Collaborator

@gianrubio gianrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianrubio, sylr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit ef3ba97 into helm:master Jan 2, 2019
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
This fix prometheus.yml output display when using `kubectl get configmap prometheus-server`

Signed-off-by: Sylvain Rabot <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants