Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/k8s-spot-termination-handler] Merge [incubator/kube-spot-termination-notice-handler] into this chart #10286

Merged
merged 3 commits into from
Feb 1, 2019

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Dec 28, 2018

What this PR does / why we need it:

Apparently, there are 2 charts for the same products in stable and incubator:

This PR merges useful changes from [incubator/kube-spot-termination-notice-handler] to [stable/k8s-spot-termination-handler]:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

cc: @egeland , @KierranM

Closes #10270 as superseded

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 28, 2018
@legal90
Copy link
Contributor Author

legal90 commented Dec 28, 2018

/assign @mattfarina

…ination-notice-handler] to this stable chart

Signed-off-by: Mikhail Zholobov <[email protected]>
It's merged to [stable/k8s-spot-termination-handler]

Signed-off-by: Mikhail Zholobov <[email protected]>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 28, 2018
@stale
Copy link

stale bot commented Jan 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2019
@legal90
Copy link
Contributor Author

legal90 commented Jan 28, 2019

Could anyone please review this PR?
cc @foxish, @lachie83, @mattfarina

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2019
Copy link
Collaborator

@egeland egeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm sad that my chart was gazumped ( 😉 ), this stable chart looks good, too! 👍

@egeland
Copy link
Collaborator

egeland commented Jan 30, 2019

Can we add in #10093 functionality, too?

@egeland
Copy link
Collaborator

egeland commented Jan 30, 2019

Would be good to get this done, so we have one canonical chart going forward.

Given this PR has lingered since 29Dec, I don't feel (too) guilty to mass-mention the approvers:
@lachie83
@prydonius
@sameersbn
@viglesiasce
@foxish
@unguiculus
@scottrigby
@mattfarina
@davidkarlsen
@paulczar
@cpanato

…on to detach from autoscaling group

Signed-off-by: Frode Egeland <[email protected]>
Signed-off-by: Mikhail Zholobov <[email protected]>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2019
@legal90
Copy link
Contributor Author

legal90 commented Jan 30, 2019

@egeland Thanks! I've appended changes from your PR #10093 to this one. 👍

@egeland
Copy link
Collaborator

egeland commented Jan 31, 2019

Hopefully one of
@lachie83
@prydonius
@sameersbn
@viglesiasce
@foxish
@unguiculus
@scottrigby
@mattfarina
@davidkarlsen
@paulczar
@cpanato
will find a few minutes to approve this PR soon... ;)

@viglesiasce
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: legal90, viglesiasce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit e3f1cd2 into helm:master Feb 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants