-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/k8s-spot-termination-handler] Merge [incubator/kube-spot-termination-notice-handler] into this chart #10286
Conversation
/assign @mattfarina |
…ination-notice-handler] to this stable chart Signed-off-by: Mikhail Zholobov <[email protected]>
It's merged to [stable/k8s-spot-termination-handler] Signed-off-by: Mikhail Zholobov <[email protected]>
3c3c23f
to
22bff14
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Could anyone please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm sad that my chart was gazumped ( 😉 ), this stable chart looks good, too! 👍
Can we add in #10093 functionality, too? |
Would be good to get this done, so we have one canonical chart going forward. Given this PR has lingered since 29Dec, I don't feel (too) guilty to mass-mention the approvers: |
…on to detach from autoscaling group Signed-off-by: Frode Egeland <[email protected]> Signed-off-by: Mikhail Zholobov <[email protected]>
Hopefully one of |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: legal90, viglesiasce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Apparently, there are 2 charts for the same products in
stable
andincubator
:incubator/kube-spot-termination-notice-handler
added by [incubator/kube-spot-termination-notice-handler] New chart #1908stable/k8s-spot-termination-handler
added by [stable/k8s-spot-termination-handler] AWS Spot termination handler #8187This PR merges useful changes from
[incubator/kube-spot-termination-notice-handler]
to[stable/k8s-spot-termination-handler]
:kubeaws/kube-spot-termination-notice-handler
which has better support and versioning.k8s-spot-termination-handler
to drain the node (the fix Kube-spot has to be able to run kubectl drain #4730 ported)incubator/kube-spot-termination-notice-handler
chart. Considered it as promoted to stable by this PR.Checklist
cc: @egeland , @KierranM
Closes #10270 as superseded