This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/elasticsearch] Tag roles for master and data #10337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
size/XS
bklang
force-pushed
the
feature/elasticsearch_roles
branch
from
a71ec0e to
7b15c9f
Compare
helm-bot
added
size/XS
This follows role conventions seen in other Helm charts and allows graphing to break out activity stats per role Signed-off-by: Ben Klang <[email protected]>
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bklang, rendhalver The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
This follows role conventions seen in other Helm charts and allows graphing to break out activity stats per role Signed-off-by: Ben Klang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows role conventions seen in other Helm charts and allows graphing to break out activity stats per role
Signed-off-by: Ben Klang [email protected]
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]