Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sonarqube] Fix plugins install #10473

Closed
wants to merge 3 commits into from
Closed

[stable/sonarqube] Fix plugins install #10473

wants to merge 3 commits into from

Conversation

rjkernick
Copy link
Collaborator

Signed-off-by: Rob Kernick [email protected]

What this PR does / why we need it: Fixes plugins installed at startup

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@rjkernick
Copy link
Collaborator Author

/ok-to-test

@rjkernick
Copy link
Collaborator Author

/retest

@k8s-ci-robot
Copy link
Contributor

@ahsan-storm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjkernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@melissapalmer
Copy link
Contributor

Please be careful of this cause of the issue raised in
#10195

The PR which I did that introduced: copy-plugins.yaml & tmp folder etc. does allow for the install of custom plugins

I failed to add the following to docs: include this in your values.yml file

command:
  - /usr/local/copy_plugins.sh

#10195 (comment)

Please do make sure that issue 10195 isn't reverted with this change.

@rjkernick
Copy link
Collaborator Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2019
@rjkernick rjkernick closed this Jan 9, 2019
@rjkernick rjkernick deleted the master branch January 9, 2019 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants