Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[ci] Upgrade to chart-testing v2.1.0 #10484

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Conversation

lachie83
Copy link
Contributor

@lachie83 lachie83 commented Jan 8, 2019

Signed-off-by: Lachlan Evenson [email protected]

Which issue this PR fixes

Changelog - https://github.com/helm/chart-testing/releases/tag/v2.1.0

Checklist

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@lachie83 lachie83 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2019
Signed-off-by: Lachlan Evenson <[email protected]>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2019
@lachie83 lachie83 assigned lachie83 and unguiculus and unassigned lachie83 Jan 8, 2019
@rimusz
Copy link
Contributor

rimusz commented Jan 11, 2019

/lgtm
/ok-to-test
Image gcr.io/kubernetes-charts-ci/test-image:v3.1.0 is already available to pull. so CI will not fail.

@k8s-ci-robot
Copy link
Contributor

@rimusz: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm
/ok-to-test
Image gcr.io/kubernetes-charts-ci/test-image:v3.1.0 is already available to pull. so CI will not fail.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lachie83
Copy link
Contributor Author

/retest

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Jan 14, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Jan 14, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2019
@lachie83 lachie83 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2019
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2019
@unguiculus
Copy link
Member

Looks good. I removed the temporary commits again.

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lachie83, rimusz, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lachie83,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3614cbc into helm:master Jan 15, 2019
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
* [ci] Upgrade to chart-testing v2.1.0

Signed-off-by: Lachlan Evenson <[email protected]>

* Update tag in build.sh

Signed-off-by: Lachlan Evenson <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
* [ci] Upgrade to chart-testing v2.1.0

Signed-off-by: Lachlan Evenson <[email protected]>

* Update tag in build.sh

Signed-off-by: Lachlan Evenson <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
* [ci] Upgrade to chart-testing v2.1.0

Signed-off-by: Lachlan Evenson <[email protected]>

* Update tag in build.sh

Signed-off-by: Lachlan Evenson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants