Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sonarqube] Update startup command when plugins are enabled #10510

Merged
merged 3 commits into from
Jan 15, 2019
Merged

[stable/sonarqube] Update startup command when plugins are enabled #10510

merged 3 commits into from
Jan 15, 2019

Conversation

rjkernick
Copy link
Collaborator

@rjkernick rjkernick commented Jan 9, 2019

Signed-off-by: Rob Kernick [email protected]

What this PR does / why we need it: Fixes issue where plugins listed in values are not installed

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Sorry, something went wrong.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2019
@rjkernick
Copy link
Collaborator Author

@melissapalmer Fixed the issues all around. Made the scripting automated when plugins are set to be installed

@rjkernick
Copy link
Collaborator Author

@ahsan-storm See above

@rjkernick
Copy link
Collaborator Author

/ok-to-test

@rjkernick rjkernick changed the title Update startup command when plugins are enabled [stable/sonarqube] Update startup command when plugins are enabled Jan 9, 2019
@rimusz
Copy link
Contributor

rimusz commented Jan 11, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@rimusz: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@melissapalmer
Copy link
Contributor

/assign scottrigby

@melissapalmer
Copy link
Contributor

/assign rjkernick

@melissapalmer
Copy link
Contributor

@rjkernick you are the only person in the OWNERS file for this chart ... are you able to add the lgtm tag? Or do you have someone else who can also add for you?

@rjkernick
Copy link
Collaborator Author

@melissapalmer I cannot approve my own request. @unguiculus Can you take a look at this pr for me?

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2019
@melissapalmer
Copy link
Contributor

/assign unguiculus

@melissapalmer
Copy link
Contributor

/unassign scottrigby

@030
Copy link
Contributor

030 commented Jan 15, 2019

Could somebody indicate when this will be merged?

@HerrmannHinz
Copy link

could need that fix as well.

@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, rimusz, rjkernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 52c624d into helm:master Jan 15, 2019
@rjkernick rjkernick deleted the document-sonarqube-overrides branch January 16, 2019 13:35
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
…elm#10510)

* Update startup command when plugins are enabled

Signed-off-by: Rob Kernick <[email protected]>

* [stable/sonarqube}] Update chart version]

Signed-off-by: Rob Kernick <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
…elm#10510)

* Update startup command when plugins are enabled

Signed-off-by: Rob Kernick <[email protected]>

* [stable/sonarqube}] Update chart version]

Signed-off-by: Rob Kernick <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
…elm#10510)

* Update startup command when plugins are enabled

Signed-off-by: Rob Kernick <[email protected]>

* [stable/sonarqube}] Update chart version]

Signed-off-by: Rob Kernick <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants