Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mariadb] Document the correct format for pullSecrets in README #10657

Merged
merged 1 commit into from
Jan 15, 2019
Merged

[stable/mariadb] Document the correct format for pullSecrets in README #10657

merged 1 commit into from
Jan 15, 2019

Conversation

carrodher
Copy link
Collaborator

Signed-off-by: Carlos Rodriguez Hernandez [email protected]

What this PR does / why we need it:

XXX.pullSecrets should be an array of secrets, this PR add some comments in the README to clarify it.
Basically, it replaces different ways of

| `image.pullSecrets` | Specify image pull secrets | `nil` |

by

| `image.pullSecrets` | Specify docker-registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) |

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019
@juan131
Copy link
Collaborator

juan131 commented Jan 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
@rimusz
Copy link
Contributor

rimusz commented Jan 15, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carrodher, juan131, rimusz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@rimusz: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 4bea457 into helm:master Jan 15, 2019
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
@carrodher carrodher deleted the mariadb branch February 27, 2019 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants