Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/rocketchat] - Add svc variable serviceType #10664

Merged
merged 2 commits into from
Jan 15, 2019
Merged

[stable/rocketchat] - Add svc variable serviceType #10664

merged 2 commits into from
Jan 15, 2019

Conversation

cesarokuti
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2019
Signed-off-by: Cesar Okuti <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2019
@cesarokuti cesarokuti changed the title [Service Type] - Add svc variable serviceType [stable/rocketchat] - Add svc variable serviceType Jan 15, 2019
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2019
@verwilst
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cesarokuti, verwilst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit f9fd0ec into helm:master Jan 15, 2019
@cesarokuti cesarokuti deleted the rocket branch January 16, 2019 11:25
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants