Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube-state-metrics] add configmap and secret collectors #10665

Merged
merged 1 commit into from
Jan 15, 2019
Merged

[stable/kube-state-metrics] add configmap and secret collectors #10665

merged 1 commit into from
Jan 15, 2019

Conversation

myauie
Copy link
Contributor

@myauie myauie commented Jan 15, 2019 •
edited
Loading

Signed-off-by: Louise Champ [email protected]

What this PR does / why we need it:

Configmap and secret collectors were added in kube-state-metrics 1.3. This PR adds templating and switches for these two collectors.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2019
@rimusz
Copy link
Contributor

rimusz commented Jan 15, 2019

/lgtm
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@rimusz: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2019
@rimusz
Copy link
Contributor

rimusz commented Jan 15, 2019

@myauie your last pushed commit needs to be DCO signed

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2019
@rimusz
Copy link
Contributor

rimusz commented Jan 15, 2019

/retest

@myauie
Copy link
Contributor Author

myauie commented Jan 15, 2019

/assign @scottrigby

@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, myauie, rimusz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0af1318 into helm:master Jan 15, 2019
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@myauie @wgiddens
add configmap and secret collectors (helm#10665)
d94d2a2 
Signed-off-by: Louise Champ <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
@myauie @hakamadare
add configmap and secret collectors (helm#10665)
a3d91a9 
Signed-off-by: Louise Champ <[email protected]>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
@myauie @hakamadare
add configmap and secret collectors (helm#10665)
aab7851 
Signed-off-by: Louise Champ <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sameersbn sameersbn Awaiting requested review from sameersbn

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@scottrigby scottrigby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@myauie @rimusz @k8s-ci-robot @davidkarlsen @scottrigby @helm-bot