-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/ambassador] Allow rbac to be namespaced #11354
[stable/ambassador] Allow rbac to be namespaced #11354
Conversation
Signed-off-by: Naseem Ullah <[email protected]>
/ok-to-test |
@steven-sheehy: GitHub didn't allow me to assign the following users: Flydiverny. Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Flydiverny |
Nice! was thinking about whether to change anything for rbac if you run ambassador in a single namespace or so :) |
Thanks @Flydiverny ! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Flydiverny, naseemkullah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Naseem Ullah <[email protected]>
What this PR does / why we need it:
Seldon Core would like to instead of deploy ambassador within it's helm chart, use the stable repo's ambassador chart as a dependency. One missing feature is the ability to allow rbac to be namespace-scoped rather than cluster-scoped.
This PR allows the end user to configure rbac to be namespace scoped if they so desire.
Which issue this PR fixes
Please see:
SeldonIO/seldon-core#445
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]