Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/ambassador] Allow rbac to be namespaced #11354

Merged
merged 1 commit into from
Feb 13, 2019
Merged

[stable/ambassador] Allow rbac to be namespaced #11354

merged 1 commit into from
Feb 13, 2019

Conversation

naseemkullah
Copy link
Collaborator

What this PR does / why we need it:

Seldon Core would like to instead of deploy ambassador within it's helm chart, use the stable repo's ambassador chart as a dependency. One missing feature is the ability to allow rbac to be namespace-scoped rather than cluster-scoped.

This PR allows the end user to configure rbac to be namespace scoped if they so desire.

Which issue this PR fixes

Please see:
SeldonIO/seldon-core#445

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@naseemkullah
Copy link
Collaborator Author

cc @kflynn @Flydiverny

Signed-off-by: Naseem Ullah <[email protected]>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@steven-sheehy
Copy link
Collaborator

/ok-to-test
/assign @Flydiverny

@k8s-ci-robot
Copy link
Contributor

@steven-sheehy: GitHub didn't allow me to assign the following users: Flydiverny.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/ok-to-test
/assign @Flydiverny

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Flydiverny
Copy link
Collaborator

/assign @Flydiverny

@Flydiverny
Copy link
Collaborator

Nice! was thinking about whether to change anything for rbac if you run ambassador in a single namespace or so :)
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@naseemkullah
Copy link
Collaborator Author

Thanks @Flydiverny !

@Flydiverny
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Flydiverny, naseemkullah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 51913b7 into helm:master Feb 13, 2019
@naseemkullah naseemkullah deleted the ambassador-namespaced-rbac branch February 13, 2019 02:59
tbuchier pushed a commit to tbuchier/charts that referenced this pull request Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants