Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Update pachyderm #11457

Merged
merged 3 commits into from
Mar 28, 2019
Merged

Update pachyderm #11457

merged 3 commits into from
Mar 28, 2019

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2019
@LaurentGoderre
Copy link
Contributor Author

@jonandernovella @dwhitena @jdoliner

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2019
@jonandernovella
Copy link
Collaborator

jonandernovella commented Feb 16, 2019 •
edited
Loading

@LaurentGoderre @jdoliner I closed this PR (#11244) because lots of ENV vars related to the storage backend seemed to change starting from pachyderm 1.8+. Take a look at the changes. It might be nice fixing this.

@LaurentGoderre
Copy link
Contributor Author

Wouldn't it be nice to at least bump it to the latest of 1.7 while 1.8 is worked on? I lost a few days hitting bugs that had already been solved in later versions

@jonandernovella
Copy link
Collaborator

@LaurentGoderre There is no need for bumping the chart to use 1.7.10. You can simply change the pachd version tag.

@jonandernovella
Copy link
Collaborator

jonandernovella commented Mar 5, 2019 •
edited
Loading

@LaurentGoderre Can you please make the following changes?

  1. Bump the chart version
  2. Replace the RoleBinding resource with ClusterRoleBinding
  3. Update all references to versions which are not 1.7.11

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2019
@LaurentGoderre
Copy link
Contributor Author

@jonandernovella done #1 and #3. What is the purpose of #2?

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Mar 6, 2019
@LaurentGoderre
Copy link
Contributor Author

Ok, done number #3

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2019
jonandernovella
jonandernovella suggested changes Mar 6, 2019
View reviewed changes
Copy link
Collaborator

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you make these small changes, it should be mergeable!

stable/pachyderm/README.md Outdated Show resolved Hide resolved
stable/pachyderm/templates/pachd_rolebinding.yaml Show resolved Hide resolved
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2019
@LaurentGoderre
Copy link
Contributor Author

Done!

@jonandernovella
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonandernovella, LaurentGoderre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2019
@jonandernovella
Copy link
Collaborator

@jdoliner LGTM. Can you take a look?

@k8s-ci-robot k8s-ci-robot merged commit 7a6e3f8 into helm:master Mar 28, 2019
@LaurentGoderre LaurentGoderre deleted the update-pachyserm branch March 28, 2019 13:33
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
@LaurentGoderre
Update pachyderm (helm#11457)
444bec9 
* Pachyderm: Added sample command for specifying the specific version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated the images version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated RoleBinding to ClusterRoleBinding

Signed-off-by: Laurent Goderre <[email protected]>
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
@LaurentGoderre
Update pachyderm (helm#11457)
bb29e44 
* Pachyderm: Added sample command for specifying the specific version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated the images version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated RoleBinding to ClusterRoleBinding

Signed-off-by: Laurent Goderre <[email protected]>
Signed-off-by: Kevin Duane <[email protected]>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@LaurentGoderre @devnulled
Update pachyderm (helm#11457)
a58f989 
* Pachyderm: Added sample command for specifying the specific version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated the images version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated RoleBinding to ClusterRoleBinding

Signed-off-by: Laurent Goderre <[email protected]>
dermorz pushed a commit to dermorz/charts that referenced this pull request Apr 26, 2019
@LaurentGoderre
Update pachyderm (helm#11457)
9fbc8cc 
* Pachyderm: Added sample command for specifying the specific version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated the images version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated RoleBinding to ClusterRoleBinding

Signed-off-by: Laurent Goderre <[email protected]>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@LaurentGoderre @goshlanguage
Update pachyderm (helm#11457)
16cd2b0 
* Pachyderm: Added sample command for specifying the specific version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated the images version

Signed-off-by: Laurent Goderre <[email protected]>

* Pachyderm: Updated RoleBinding to ClusterRoleBinding

Signed-off-by: Laurent Goderre <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonandernovella jonandernovella jonandernovella requested changes

@jdoliner jdoliner Awaiting requested review from jdoliner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LaurentGoderre @jonandernovella @k8s-ci-robot @helm-bot