This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/sonatype-nexus] Reorder host names in ingress #11513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `nexusHttpHost` the first in the list of TLS hosts. This is to ensure that the common name (as displayed in the browser) in the generated Let's Encrypt TLS certificate is the `nexusHttpHost`, while `nexusDockerHost` is added to subject alternative names. Signed-off-by: Sergei Ivanov <[email protected]>
helm-bot
added
Contribution Allowed
|
/assign @rjkernick |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjkernick, sergei-ivanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make
nexusHttpHostthe first in the list of TLS hosts.This is to ensure that the common name (as displayed in the browser) in the generated Let's Encrypt TLS certificate is the
nexusHttpHost, whilenexusDockerHostis added to subject alternative names.Which issue this PR fixes
N/A
Special notes for your reviewer:
N/A
Checklist