Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Bump Ambassador version to 0.50.3. #11657

Merged
merged 14 commits into from
Feb 24, 2019
Merged

Bump Ambassador version to 0.50.3. #11657

merged 14 commits into from
Feb 24, 2019

Conversation

kflynn
Copy link
Collaborator

@kflynn kflynn commented Feb 22, 2019

Bump Ambassador chart to Ambassador version 0.50.3.

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2019
@steven-sheehy
Copy link
Collaborator

/approve
/assign @Flydiverny
/ok-to-test

@Flydiverny
Copy link
Collaborator

Think it makes sense to update maintainers on chart! Also just like to note that when we changed from kflynn to flynn in the maintainers the link on https://hub.helm.sh/charts/stable/ambassador now points wrongly to the github organisation flynn :)

@steven-sheehy
Copy link
Collaborator

Yeah, it should be kflynn in Chart.yaml since that's the github userid. I added a comment.

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 23, 2019
@Flydiverny
Copy link
Collaborator

@kflynn missing sign-off :)

@kflynn
Copy link
Collaborator Author

kflynn commented Feb 24, 2019

Oh for crying out loud... 😆 I don't suppose I can tell the bot that no, really, the fact that my commits are GPG-signed is good enough??? 😄

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2019
@kflynn
Copy link
Collaborator Author

kflynn commented Feb 24, 2019

(Thanks for the sharp eyes, @Flydiverny and @steven-sheehy. 😄 )

@Flydiverny
Copy link
Collaborator

😂
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Flydiverny, kflynn, steven-sheehy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 02b2d34 into helm:master Feb 24, 2019
monotek pushed a commit to monotek/charts that referenced this pull request Mar 7, 2019
* Restore default replicas == 3

Signed-off-by: Flynn <[email protected]>

* Fix some markdown

Signed-off-by: Flynn <[email protected]>

* Bump chart version, and switch my name to Flynn. :)

Signed-off-by: Flynn <[email protected]>

* Add icon.

Signed-off-by: Flynn <[email protected]>

* Sort OWNERS, and add nbkrause (from Datawire)

Signed-off-by: Flynn <[email protected]>

* Heh. Didn't realize a change to OWNERS required a version bump.

Signed-off-by: Flynn <[email protected]>

* Bump to Ambassador 0.50.2.

Signed-off-by: Flynn <[email protected]>

* Bump Ambassador to version 0.50.3.

Signed-off-by: Flynn <[email protected]>

* Augh. Fix Ambassador versions in values.yaml and README.

Signed-off-by: Flynn <[email protected]>

* Update chart maintainers per PR comments

Signed-off-by: Flynn <[email protected]>
rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
* Restore default replicas == 3

Signed-off-by: Flynn <[email protected]>

* Fix some markdown

Signed-off-by: Flynn <[email protected]>

* Bump chart version, and switch my name to Flynn. :)

Signed-off-by: Flynn <[email protected]>

* Add icon.

Signed-off-by: Flynn <[email protected]>

* Sort OWNERS, and add nbkrause (from Datawire)

Signed-off-by: Flynn <[email protected]>

* Heh. Didn't realize a change to OWNERS required a version bump.

Signed-off-by: Flynn <[email protected]>

* Bump to Ambassador 0.50.2.

Signed-off-by: Flynn <[email protected]>

* Bump Ambassador to version 0.50.3.

Signed-off-by: Flynn <[email protected]>

* Augh. Fix Ambassador versions in values.yaml and README.

Signed-off-by: Flynn <[email protected]>

* Update chart maintainers per PR comments

Signed-off-by: Flynn <[email protected]>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
* Restore default replicas == 3

Signed-off-by: Flynn <[email protected]>

* Fix some markdown

Signed-off-by: Flynn <[email protected]>

* Bump chart version, and switch my name to Flynn. :)

Signed-off-by: Flynn <[email protected]>

* Add icon.

Signed-off-by: Flynn <[email protected]>

* Sort OWNERS, and add nbkrause (from Datawire)

Signed-off-by: Flynn <[email protected]>

* Heh. Didn't realize a change to OWNERS required a version bump.

Signed-off-by: Flynn <[email protected]>

* Bump to Ambassador 0.50.2.

Signed-off-by: Flynn <[email protected]>

* Bump Ambassador to version 0.50.3.

Signed-off-by: Flynn <[email protected]>

* Augh. Fix Ambassador versions in values.yaml and README.

Signed-off-by: Flynn <[email protected]>

* Update chart maintainers per PR comments

Signed-off-by: Flynn <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants