Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cockroachdb] Additional parameters for cockroachdb #11747

Merged
merged 4 commits into from
Feb 28, 2019
Merged

[stable/cockroachdb] Additional parameters for cockroachdb #11747

merged 4 commits into from
Feb 28, 2019

Conversation

trevex
Copy link
Contributor

@trevex trevex commented Feb 26, 2019

What this PR does / why we need it:

Currently it is not possible to provide advanded command line arguments for cockroachdb or to provide additional secrets for the cluster members.

This PR introduces two variables:

  • ExtraArgs to provide additional command-line arguments
  • ExtraSecretMounts to mount arbitrary secrets

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @trevex. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 26, 2019
@trevex
Copy link
Contributor Author

trevex commented Feb 26, 2019

/assign @a-robinson

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2019
@trevex
Copy link
Contributor Author

trevex commented Feb 26, 2019

/cc @robert-s-lee

@k8s-ci-robot
Copy link
Contributor

@trevex: GitHub didn't allow me to request PR reviews from the following users: robert-s-lee.

Note that only helm members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @robert-s-lee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miouge1
Copy link
Collaborator

Miouge1 commented Feb 26, 2019

This adds a new feature so it should bump the "middle" number in the version: 2.1.0

@trevex trevex force-pushed the feature/cockroachdb-additional-parameters branch from 0f4c4b4 to c50a90e Compare February 27, 2019 08:13
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2019
@trevex
Copy link
Contributor Author

trevex commented Feb 27, 2019

@Miouge1 rebased and amend bump version commit

a-robinson
a-robinson approved these changes Feb 28, 2019
View reviewed changes
Copy link
Collaborator

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @trevex!

@a-robinson
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-robinson, trevex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit fbc9f1d into helm:master Feb 28, 2019
cdenneen added a commit to cdenneen/charts that referenced this pull request Feb 28, 2019
@cdenneen
Merge branch 'master' of https://github.com/helm/charts into sslcerth…
2ca0fd2 
…ostpath

* 'master' of https://github.com/helm/charts: (1475 commits)
  added additional ports option for prometheus-operator prometheus service (helm#11506)
  [incubator/kafka] fix NOTES.txt: update script paths (helm#11503)
  helm#11812 allow hostPath as datadir (helm#11815)
  [stable/mongodb-replica-set] Fix metrics livenessProbe and regression in securityContext (helm#11819)
  [stable/mariadb] Add PodDisruptionBudget for MariaDB (helm#11417)
  fix hoard secrets id (helm#11835)
  fix: add missed template for serviceaccount and add basic RBAC resources (helm#11742)
  expose container port so it can be scraped (helm#11831)
  Feature/kuberhealthy pod annotations (helm#11651)
  [stable/prometheus-operator] Update deps for grafana v6 (helm#11824)
  [stable/auto-scaler] Add explicit awsRegion step in README (helm#11822)
  Add efs-provisioner mountOptions (helm#11821)
  fixes for kuberhealthy/kuberhealthy#121 (helm#11829)
  [stable/cockroachdb] Additional parameters for cockroachdb (helm#11747)
  Allow for overriding of proxy/admin listen (helm#11362)
  [stable/drupal] Add apiVersion in Chart.yaml and add test info to README.md (helm#11810)
  [stable/joomla] Add apiVersion in Chart.yaml and add test info to README.md (helm#11809)
  [stable/jasperreports] Add apiVersion in Chart.yaml and add test info to README.md (helm#11808)
  [stable/ghost] Add apiVersion in Chart.yaml and add test info to README.md (helm#11807)
  [stable/mariadb] Add apiVersion in Chart.yaml and add test info to README.md (helm#11806)
  ...
monotek pushed a commit to monotek/charts that referenced this pull request Mar 7, 2019
@trevex
[stable/cockroachdb] Additional parameters for cockroachdb (helm#11747)
c02963c 
* Add ExtraArgs and ExtraSecretMounts for additional configurability.

Signed-off-by: Niklas Voss <[email protected]>

* Bump version.

Signed-off-by: Niklas Voss <[email protected]>

* Updated README to include new values.

Signed-off-by: Niklas Voss <[email protected]>

* Removed blank line to avoid linting errors.

Signed-off-by: Niklas Voss <[email protected]>
alvgarvilla pushed a commit to alvgarvilla/charts that referenced this pull request Mar 13, 2019
@trevex @alvgarvilla
[stable/cockroachdb] Additional parameters for cockroachdb (helm#11747)
311ead1 
* Add ExtraArgs and ExtraSecretMounts for additional configurability.

Signed-off-by: Niklas Voss <[email protected]>

* Bump version.

Signed-off-by: Niklas Voss <[email protected]>

* Updated README to include new values.

Signed-off-by: Niklas Voss <[email protected]>

* Removed blank line to avoid linting errors.

Signed-off-by: Niklas Voss <[email protected]>
rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
@trevex @rmccorm4
[stable/cockroachdb] Additional parameters for cockroachdb (helm#11747)
ef4669e 
* Add ExtraArgs and ExtraSecretMounts for additional configurability.

Signed-off-by: Niklas Voss <[email protected]>

* Bump version.

Signed-off-by: Niklas Voss <[email protected]>

* Updated README to include new values.

Signed-off-by: Niklas Voss <[email protected]>

* Removed blank line to avoid linting errors.

Signed-off-by: Niklas Voss <[email protected]>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@trevex @devnulled
[stable/cockroachdb] Additional parameters for cockroachdb (helm#11747)
ffe5295 
* Add ExtraArgs and ExtraSecretMounts for additional configurability.

Signed-off-by: Niklas Voss <[email protected]>

* Bump version.

Signed-off-by: Niklas Voss <[email protected]>

* Updated README to include new values.

Signed-off-by: Niklas Voss <[email protected]>

* Removed blank line to avoid linting errors.

Signed-off-by: Niklas Voss <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-robinson a-robinson a-robinson approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@a-robinson a-robinson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trevex @k8s-ci-robot @Miouge1 @a-robinson @helm-bot