Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Bugfix secrets for sidecar role #15750

Merged
merged 3 commits into from
Jul 23, 2019
Merged

[stable/grafana] Bugfix secrets for sidecar role #15750

merged 3 commits into from
Jul 23, 2019

Conversation

fr-ser
Copy link
Contributor

@fr-ser fr-ser commented Jul 22, 2019 •
edited
Loading

Give the secrets authorization also to the role and not only the clusterrole

What this PR does / why we need it: #13492

Which issue this PR fixes

  • fixes: Add secrets resource to role (not only clusterrole)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@fr-ser
[stable/grafana] Bugfix secrets for sidecar role
d06c4f9 
Give the secrets authorization also to the role and not only the
clusterrole

Signed-off-by: Sergej Herbert <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2019
@k8s-ci-robot k8s-ci-robot requested a review from zanhsieh July 22, 2019 12:45
@k8s-ci-robot
Copy link
Contributor

Hi @fr-ser. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2019
@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
zanhsieh
zanhsieh reviewed Jul 23, 2019
View reviewed changes
stable/grafana/Chart.yaml Outdated Show resolved Hide resolved
@zanhsieh
Copy link
Collaborator

/retest

@zanhsieh
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fr-ser, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit dea5ea4 into helm:master Jul 23, 2019
@replicated-ship replicated-ship bot mentioned this pull request Jul 23, 2019
Open
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
@fr-ser
[stable/grafana] Bugfix secrets for sidecar role (helm#15750)
4ab55c0 
* [stable/grafana] Bugfix secrets for sidecar role

Give the secrets authorization also to the role and not only the
clusterrole

Signed-off-by: Sergej Herbert <[email protected]>

* [stable/grafana] Bugfix secrets sidecar version

Version bump

Signed-off-by: Sergej Herbert <[email protected]>
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@fr-ser @kengou
[stable/grafana] Bugfix secrets for sidecar role (helm#15750)
17ac49f 
* [stable/grafana] Bugfix secrets for sidecar role

Give the secrets authorization also to the role and not only the
clusterrole

Signed-off-by: Sergej Herbert <[email protected]>

* [stable/grafana] Bugfix secrets sidecar version

Version bump

Signed-off-by: Sergej Herbert <[email protected]>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@fr-ser
[stable/grafana] Bugfix secrets for sidecar role (helm#15750)
d1e299b 
* [stable/grafana] Bugfix secrets for sidecar role

Give the secrets authorization also to the role and not only the
clusterrole

Signed-off-by: Sergej Herbert <[email protected]>

* [stable/grafana] Bugfix secrets sidecar version

Version bump

Signed-off-by: Sergej Herbert <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanhsieh zanhsieh zanhsieh approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fr-ser @k8s-ci-robot @zanhsieh @helm-bot